Open
Conversation
Bumps [stylelint](https://github.com/stylelint/stylelint) from 17.4.0 to 17.6.0. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@17.4.0...17.6.0) --- updated-dependencies: - dependency-name: stylelint dependency-version: 17.6.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
The ember-canary CI check failed after stylelint
was updated from 17.4.0 to 17.6.0.
Root cause: The ember-canary test scenario was encountering a TypeError when
creating the EmberApp instance, attempting to read the 'debug' property from an
undefined 'defaults' parameter. This suggests that in certain scenarios
(particularly with ember-canary using ember-cli 6.9.x with Ember 7.0.0-alpha),
the async function in ember-cli-build.js may be called without proper parameter
passing, resulting in undefined being passed as the defaults argument.
Fix: Added a default parameter value (`defaults = {}`) to the async function
in ember-cli-build.js. This ensures that if no defaults are provided or if
undefined is passed, an empty object is used instead, preventing the TypeError
when EmberApp attempts to access properties on the defaults object.
Risk: Low risk. This is a defensive coding practice that provides a sensible
fallback. An empty defaults object is a valid input for EmberApp constructor,
and this change only affects scenarios where defaults would have been undefined
(which was causing failures). Normal scenarios where defaults is properly passed
will continue to work identically.
Files changed:
- test-app/ember-cli-build.js
Automated fix by veni-vidi-fixi
The ember-canary CI check failed after stylelint was updated from 17.4.0 to 17.6.0. Root cause: The ember-canary test scenario uses ember-source 7.0.0-alpha (canary), which no longer provides the traditional addon structure with paths.debug and paths.prod properties. When EmberApp._initVendorFiles() tried to access emberSource.paths.debug, it threw a TypeError because paths was undefined. This is a fundamental incompatibility between ember-source 7.0 canary and the traditional ember-cli build process. Fix: Configured EmberApp to skip vendor file resolution by setting vendorFiles for 'ember.js' and 'ember-testing.js' to null. This is appropriate because the project uses @embroider/vite, which handles module resolution through Vite's build system rather than ember-cli's traditional vendor concatenation. The vendor files configuration override prevents EmberApp from attempting to access the non-existent paths property on ember-source 7.0. Risk: Low risk. This change only affects the ember-cli configuration phase and does not change runtime behavior. Embroider+Vite builds already bypass the traditional vendor file concatenation, so explicitly marking these as null simply makes the configuration match the actual build process. Tested locally with successful build. Files changed: - test-app/ember-cli-build.js Automated fix by veni-vidi-fixi
Contributor
Author
|
A newer version of stylelint exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps stylelint from 17.4.0 to 17.6.0.
Release notes
Sourced from stylelint's releases.
Changelog
Sourced from stylelint's changelog.
Commits
f74ceafRelease 17.6.0 (#9180)895f7f2Add support for extending units tolanguageOptions(#9166)dd7231bRefactor to replaceimurmurhashwithnode:crypto(#9177)5b6b024Bump picomatch (#9178)7e25378Bump@csstools/css-syntax-patches-for-csstreefrom 1.0.29 to 1.1.1 in the css...9edeff4Groupcsstreeand@csstools/css-syntax-patches-for-csstreein dependabot ...2f7c0caBump actions/download-artifact from 8.0.0 to 8.0.1 (#9167)59f310dBump write-file-atomic from 7.0.0 to 7.0.1 (#9169)ab2ffcbBump@vscode/windows-process-treefrom 0.6.3 to 0.7.0 (#9170)a9f3e5bBump lint-staged from 16.3.3 to 16.4.0 (#9171)Install script changes
This version modifies
preparescript that runs during installation. Review the package contents before updating.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)